Fix RISC-V Test Failures in ./x test for Multiple Codegen and Assembly Cases #143792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
| @@ -0,0 +1,127 @@ | |||
| //@ compile-flags: -Copt-level=0 -Cno-prepopulate-passes | |||
There was a problem hiding this comment.
Why split this out to a separate file? Skimming the contents I don't see major differences vs the existing file. Maybe we could use revisions instead if there's a few small differences (see tests/codegen/sanitizer/kcfi/emit-kcfi-operand-bundle-itanium-cxx-abi-generalized.rs for example).
There was a problem hiding this comment.
The difference lies in the // CHECK lines. Would it be possible to separate them using revisions?
Merge no-riscv64 and riscv64
Merge no-riscv64 and riscv64.
rustbot
removed
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and resolves several test failures that occurred when running
./x teston the RISC-V architecture. The issues were due to platform-specific behavior, ABI differences, or code generation inconsistencies specific to RISC-V.The following tests have been fixed:
assembly/dwarf-mixed-versions-lto.rscodegen/const-vector.rscodegen/enum/enum-aggregate.rscodegen/simd/extract-insert-dyn.rscodegen/transmute-scalar.rscodegen/uninhabited-transparent-return-abi.rsAll changes have been tested locally with
./x teston a RISC-V target and now pass as expected.Notes: